infra/samba-pki-tools
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[IMP] Check False for run subprocess

Browse Source
This commit is contained in:
Kevin GUERINEAU
2024-05-07 22:16:16 +02:00
parent 99e59db13d
commit 1aa3c79ef7
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
common.py
+3 -3
View File
@@ -257,13 +257,13 @@ def create_openssl_intermediate(name, force=False,verbose=False):
if not os.path.isfile(TisPKI.intermediate_ca_keyfile(name)) and not os.path.isfile(TisPKI.intermediate_ca_certfile(name)): if not os.path.isfile(TisPKI.intermediate_ca_keyfile(name)) and not os.path.isfile(TisPKI.intermediate_ca_certfile(name)):
Printing.information('Generate Intermediate CA private key and CSR') Printing.information('Generate Intermediate CA private key and CSR')
gen_intermediate_ca = subprocess.run(f"/usr/bin/openssl req -config {intermediate_ca_config} -new -sha512 -keyout {TisPKI.intermediate_ca_keyfile(name)} \ gen_intermediate_ca = subprocess.run(f"/usr/bin/openssl req -config {intermediate_ca_config} -new -sha512 -keyout {TisPKI.intermediate_ca_keyfile(name)} \
-out {TisPKI.intermediate_csr_path(name)}/{name.replace(' ','_')}_intermediate_ca.csr", shell=True, check=True, executable='/bin/bash') -out {TisPKI.intermediate_csr_path(name)}/{name.replace(' ','_')}_intermediate_ca.csr", shell=True, check=False, executable='/bin/bash')
if gen_intermediate_ca.returncode == 0: if gen_intermediate_ca.returncode == 0:
Printing.information('Sign Intermediate CA with Root CA') Printing.information('Sign Intermediate CA with Root CA')
sign_intermediate_ca = subprocess.run(f"/usr/bin/openssl ca -config {os.path.join(TisPKI.root_config_path(),'openssl_root_ca_sign_intermediate.ini')} \ sign_intermediate_ca = subprocess.run(f"/usr/bin/openssl ca -config {os.path.join(TisPKI.root_config_path(),'openssl_root_ca_sign_intermediate.ini')} \
-extensions v3_intermediate_ca -days 1825 -notext -md sha512 -create_serial -in {TisPKI.intermediate_csr_path(name)}/{name.replace(' ','_')}_intermediate_ca.csr \ -extensions v3_intermediate_ca -days 1825 -notext -md sha512 -create_serial -in {TisPKI.intermediate_csr_path(name)}/{name.replace(' ','_')}_intermediate_ca.csr \
-out {TisPKI.intermediate_ca_certfile(name)}", shell=True, check=True, executable='/bin/bash') -out {TisPKI.intermediate_ca_certfile(name)}", shell=True, check=False, executable='/bin/bash')
if sign_intermediate_ca.returncode == 0: if sign_intermediate_ca.returncode == 0:
if verbose: if verbose:
@@ -277,7 +277,7 @@ def create_openssl_intermediate(name, force=False,verbose=False):
os.remove(TisPKI.intermediate_ca_keyfile(name)) os.remove(TisPKI.intermediate_ca_keyfile(name))
create_openssl_intermediate(name, force, verbose) create_openssl_intermediate(name, force, verbose)
else: else:
Printing.error('Error on generating Root CA private key') Printing.error('Error on generating Intermediate CA private key')
retry = input('If you want to retry, press Y : ') retry = input('If you want to retry, press Y : ')
if retry == "y" or retry == 'Y': if retry == "y" or retry == 'Y':
os.remove(TisPKI.intermediate_ca_keyfile(name)) os.remove(TisPKI.intermediate_ca_keyfile(name))